feat(genai): add logprobs support #1266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroon0x
changed the title
mdrxy
changed the title
mdrxy
reviewed
Nov 10, 2025
| """Stop sequences for the model.""" | ||
|
|
||
| logprobs: int | None = None | ||
| """The number of logprobs to return.""" |
Collaborator
There was a problem hiding this comment.
Is this correct? It doesn't appear to affect output for me. Setting to 0 (or False) also appears to still keep chosen_candidates
Collaborator
|
I also think we ought to mention the instability of the param https://discuss.ai.google.dev/t/logprobs-is-not-enabled-for-gemini-models/107989/15 I can't get newer Gemini models (2.5) to return logprobs via the genai API either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement logprobs support in chat_models.py to
ChatGoogleGenerativeAIRelevant issues
Fixes #718
Type
🆕 New Feature
✅ Test
Changes(optional)
Files changed
chat_models.pyandtest_chat_models.pyTesting(optional)
Added
test_logprobsfunction intest_chat_models.pyNote(optional)